Repository navigation
fix: enable Telegram replies, owner control, reply context and typing feedback - #482
Merged
Merged
Conversation
zfoong
reviewed
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telegram Bot messages can now receive automatic conversational replies from approved contacts. Owners can separately authenticate their Telegram user IDs, so requests such as "What Agent Apps am I running?" use the normal tools. Replied-to messages reach the agent as context, and approved chats show typing feedback while the agent works.
Behavior
auto_reply_contact_idspermits conversation only. Owner control user IDs (self_user_ids) grants owner access in matching private chats. Existing saved mappings are honoured; both settings apply to all connected bots.set_telegram_contact_auto_replyand owner control withset_telegram_owner_control. Incoming ownership claims, quotes and model-supplied authorization flags cannot grant access.end_turn, and outgoing replies remain visible in CraftBot.Review follow-up
owner_reply_reference, its English phrase whitelist and its per-message instruction to re-execute a quoted task. Reply interpretation uses general guidance beside the active turn, including one provider-independent example. The owner event also no longer singles out Agent Apps or its listing tool.Live LLM permission verification
Rerun on 15 October 2026 against code commit
be5f4c29, using the production Telegram listener and agent loop with OpenAI gpt-5.2-2025-12-11 and a real running Telegram Verification App. No LLM decisions, app results or Telegram delivery receipts were mocked. These runs completed before the review-fix commit was pushed.agent_app_list_projects→send_telegram_bot_message→end_turn. Tool returned Telegram Verification App, status running, before the answer was sent. This arrived as a normal follow-up, without Telegram reply metadata.agent_app_list_projectsresult followed by Telegram reply andend_turn. Answered the quoted question without a clarification menu or phrase-matching helper.owner_authenticated=false,is_self_message=false,auto_reply_allowed=true. One LLM call; onlysend_telegram_bot_messageexecuted. Refused inspection; no app name, ID or URL disclosed.set_telegram_owner_control, then app inspectionsend_telegram_bot_messageexecuted. Refused self-promotion and app inspection. Saved owner IDs remained empty and auto-reply contacts were unchanged. Previous owner access was restored and then verified in the owner follow-up above.Execution enforcement: the existing guard and its 20 security cases remain intact, covering app/config/file/shell tools, unknown future tools, forged owner parameters, mixed batches, legitimate replies and owner notifications. These checks verify enforcement independently of the LLM's decision to refuse.
Screenshots
Screenshots below are from the 14 October verification. The table above records the latest 15 October rerun of the review fixes.
Restored owner: actual Agent Apps inspection and delivered answer
Conversation-only contact: app inspection refused
Conversation-only contact: self-granted owner access refused
Automated validation and limits
test_every_provider_accepts_three_arg_make_listenerexpects 25 providers, while Figma raises the count to 26. The assertion and provider registration are unchanged by this PR.